Skip to content

docs: adds screen.logToTestingPlaygroundURL method #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2020
Merged

docs: adds screen.logToTestingPlaygroundURL method #715

merged 2 commits into from
Dec 17, 2020

Conversation

tometo-dev
Copy link
Contributor

No description provided.

@tometo-dev
Copy link
Contributor Author

Can someone point me in the right direction? Why have all the checks failed?

@MatanBobi
Copy link
Member

Hi @tsuki42! Thanks for taking the time to put this one together :)
From the Deploy preview step details
you can see that it failed on the build step so I'd first try to run the command locally and see if it's working.
Though it looks like you've added another backtick to the code blocks so it might be that.. Give it a try :) I'd also recommend testing it locally to see that it's working as you expect..

@tometo-dev
Copy link
Contributor Author

Those extra backticks were added automatically during commit phase by lint-staged. I didn't even see them. My bad. I'll make the changes and try again. Thanks.

@tometo-dev tometo-dev marked this pull request as draft December 16, 2020 06:58
@MatanBobi
Copy link
Member

Those extra backticks were added automatically during commit phase by lint-staged. I didn't even see them. My bad. I'll make the changes and try again. Thanks.

No worries, if that's being added by our prettier configs we should fix that.
I see that it's still failing, did you manage to run the build command locally?

@tometo-dev
Copy link
Contributor Author

Those backticks were added again. I passed the --no-verify to bypass them and force-pushed the changes. Still failing.

@MatanBobi
Copy link
Member

MatanBobi commented Dec 16, 2020

It looks like the prettier fixes messed up the line breaks for Tabs and TabItem..
We need to look into it, I'll try to get to it today and figure out why this happens.
For now, I pushed a fix to your branch :)

Oh, I see now that you've reverted the other changes. Thanks!

@tometo-dev
Copy link
Contributor Author

Yeah. I had reverted the changes back to master and redid the docs and the checks had passed.

@tometo-dev
Copy link
Contributor Author

Cleaned the commit messages. It is now ready for the review. Thanks.

@tometo-dev tometo-dev marked this pull request as ready for review December 16, 2020 08:13
@MatanBobi
Copy link
Member

Thanks for this one @tsuki42!

@MatanBobi MatanBobi merged commit 362439f into testing-library:master Dec 17, 2020
@MatanBobi
Copy link
Member

@all-contributors please add @tsuki42 for docs

@allcontributors
Copy link
Contributor

@MatanBobi

I've put up a pull request to add @tsuki42! 🎉

@tometo-dev
Copy link
Contributor Author

Thanks for this one @tsuki42!

My pleasure.

@tometo-dev tometo-dev deleted the add-logTestingPlaygroundURL-api branch December 17, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants