-
Notifications
You must be signed in to change notification settings - Fork 728
feat: convert npm to yarn commands on docs #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the suggestion. Since the change from npm to yarn is quite trivial and this plugin isn't trivial we just stick with |
Personally I think this would be worth reopening. New users don't necessarily know how to translate npm commands to yarn commands, and from a maintenance perspective this remark transformer makes it much easier to add both sets of commands to our docs (compared to manually adding Tabs, TabItems, and Yarn examples to each document). |
Now, this is even easier... because Docusaurus ships the plugin I've implemented here but inside a module. If you're all agree, I can adjust the pull request adding this module. 👍 |
That sounds like a good idea, let's reopen it to try it out, and we can review it again. |
fe250ab
to
6a9e885
Compare
@nickmccurdy Done mate! Noticed one issue with one link:
But not sure where it should point, I can fix it if you give me some extra details. Also could be interesting to update the netlify node version: 10 is not longer maintained. 8:34:25 PM: You are using Node.js v10.24.1. We require Node.js >=12.13.0 or up! |
@semoal Could you rebase this? We're still interested in landing this. |
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a few pages and this looks good to me.
@all-contributors add @semoal for code |
I've put up a pull request to add @semoal! 🎉 |
Hey folks 👋
I've introduced this little plugin to introduce automatic conversion of npm commands to yarn.
Demo: