Update NTL docs #91
Update NTL docs #91
Conversation
| @@ -105,9 +105,6 @@ class Index extends React.Component { | |||
| the more confidence they can give you. | |||
| </i> | |||
| </p> | |||
| <MarkdownBlock> | |||
There was a problem hiding this comment.
It would be cool to have this animate a transition between the different libraries
There was a problem hiding this comment.
Can do this as a followup
website/pages/en/index.js
Outdated
| imageAlign: 'top', | ||
| title: '[And more...](./docs/ecosystem-user-event)', | ||
| title: '[Native Testing Library](./react-native)', |
There was a problem hiding this comment.
Can you leave the ecosystem link here and make a standard thumbnail for react native?
There was a problem hiding this comment.
Yep I can leave the ecosystem one in there.
Disclosure, the reason I took it out was that it was the last non-implementation package so it seemed out of place, and it looks maaad weird when there's two items in this last row. Do you think there's one more thing we could put in this table so it's all 3 across?
Also react native and react have the same logo weirdly. Do you want me to just copy the react logo and name it react-native?
There was a problem hiding this comment.
You can change it to 2, 3, or 4 columns, might look better
There was a problem hiding this comment.
Looks like the RN site uses a white-on-black React logo, how about using a black one for RN?
There was a problem hiding this comment.
I'll try to do this this evening, as part of it do you want me to remove the link to each landing page? I think we should probably delete the pages separately because some of the libraries (at least RTL) link to their landing page from their readme.
There was a problem hiding this comment.
You can place redirects in netlify.toml from the landing pages to the docs pages
There was a problem hiding this comment.
I'm not sure how exactly to manage the landing pages. They seem to be getting a little out of hand and they are almost all the same copy-pasted code. A couple ideas:
- Keep using landing pages. Implement the changes in this PR to make the root generic, but also a new index page for
dom-testing-librarythat is the same as the previous homepage. - Genericize the index page and delete the other homepages; make the intro.md files a little nicer with logos and a little marketing blurb at the top.
I'm inclined to do the second one to get readers into the main docs faster, prevent sending SEO traffic to subpages, and lower the maintenance burden.
|
I'd gravitate toward option 2, I'll be honest until I did this I don't think I even knew the landing pages existed 😬 |
…sting-library-docs into pr/update-native-docs
|
Alrighty, react-native thumbnail added, ecosystem link added back. landing pages removed, and netlify redirects set up. I think we're good to go on this one 👍 |
|
@allcontributors[bot] please add @bcarroll22 for code |
|
I've put up a pull request to add @bcarroll22! 🎉 |
alexkrolick
dismissed
their stale review
need to replace landing pages w/intro pages
|
Addressed 👍 |
|
This is awesome |
This is a first pass at getting more about NTL and its ecosystem on the main docs site. I also tried to change as much as I could to point to the new org and remove "DOM" stuff from the main landing page.
Let me know if I missed anything. I think this probably gets enough on the main docs site to make it feel "first class" but for now I still think its beneficial to leave the native site up for more comprehensive docs on native.