Skip to content

standardize styling and css #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 6, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,4 @@ jobs:

- name: Check linting
working-directory: ./typescript
run: npm run lint:check
run: npm run lint
1 change: 0 additions & 1 deletion typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"check": "tsc --noEmit",
"lint": "eslint src --ext .ts,.tsx",
"lint:fix": "eslint src --ext .ts,.tsx --fix",
"lint:check": "eslint src --ext .ts,.tsx --max-warnings 0",
"prepare": "husky"
},
"keywords": [
Expand Down
28 changes: 9 additions & 19 deletions typescript/src/examples/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,32 +6,22 @@ import { HeadingBlockRenderer } from "@/renderer/components/blocks/HeadingBlockR

import { JsonDocRenderer } from "../renderer/JsonDocRenderer";

// import testPage from "./testJsonDocs/test_document.json";
import testPage from "./testJsonDocs/ex1_success.json";
// import testPage from "./testJsonDocs/test_document_2.json";

const App = () => {
// async function main() {
// const schema = await loadSchema("./testJsonDocs/test_document_2.json");

// try {
// const isValid = validateAgainstSchema(testPage, schema);
// console.log("isvlaid: ", isValid);
// console.log("schema: ", schema);
// } catch (error) {
// console.log("error validating schema: ", error);
// }
// }

// useEffect(() => {
// main();
// }, []);

return (
<div style={{ padding: "20px", maxWidth: "800px", margin: "0 auto" }}>
<div
style={{
padding: "20px",
maxWidth: "800px",
margin: "0 auto",
background: "black",
}}
>
<h1>JSON-DOC Renderer Development</h1>
<JsonDocRenderer
page={testPage}
theme="dark"
components={{
heading_1: (props) => {
return <HeadingBlockRenderer {...props} />;
Expand Down
6 changes: 4 additions & 2 deletions typescript/src/renderer/JsonDocRenderer.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
import "./styles/index.css";
import React from "react";

import { BlockRenderer } from "./components/BlockRenderer";
import "./styles.css";

interface JsonDocRendererProps {
page: any;
className?: string;
components?: React.ComponentProps<typeof BlockRenderer>["components"];
theme?: "light" | "dark";
}

export const JsonDocRenderer = ({
page,
className = "",
components,
theme = "light",
}: JsonDocRendererProps) => {
return (
<div className={`json-doc-renderer ${className}`}>
<div className={`json-doc-renderer jsondoc-theme-${theme} ${className}`}>
<div className="json-doc-page">
{/* Page icon */}
{page.icon && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,11 @@ export const CodeBlockRenderer: React.FC<CodeBlockRendererProps> = ({
>
<div>
<div role="figure">
<div>
<div>
<div>{codeData?.language || "Plain Text"}</div>
</div>
<div className="notion-code-block-language">
{codeData?.language || "Plain Text"}
</div>
<div>
<div className="line-numbers notion-code-block">
<div className="line-numbers notion-code-block-content">
<div className="notranslate">
<RichTextRenderer richText={codeData?.rich_text || []} />
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,14 @@ export const ParagraphBlockRenderer: React.FC<ParagraphBlockRendererProps> = ({
components,
...props
}) => {
console.log("block.paragraph: ", block.paragraph);
console.log("block children:", block.children);
return (
<div
{...props}
className={`notion-selectable notion-text-block ${className || ""}`.trim()}
data-block-id={block.id}
>
<div>
<div>
<div className="notranslate">
<RichTextRenderer richText={block.paragraph?.rich_text || []} />
</div>
</div>
<div className="notranslate">
<RichTextRenderer richText={block.paragraph?.rich_text || []} />
</div>

{/* Render children blocks recursively */}
Expand Down
6 changes: 5 additions & 1 deletion typescript/src/renderer/index.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
export { JsonDocRenderer } from "./JsonDocRenderer";
export { BlockRenderer } from "./components/BlockRenderer";

// Export individual block components for composition
export { ParagraphBlockRenderer } from "./components/blocks/ParagraphBlockRenderer";
export { HeadingBlockRenderer } from "./components/blocks/HeadingBlockRenderer";
export { ListItemBlockRenderer } from "./components/blocks/ListItemBlockRenderer";

export { CodeBlockRenderer } from "./components/blocks/CodeBlockRenderer";
export { ImageBlockRenderer } from "./components/blocks/ImageBlockRenderer";
export { TableBlockRenderer } from "./components/blocks/TableBlockRenderer";
export { JsonDocRenderer } from "./JsonDocRenderer";
export { QuoteBlockRenderer } from "./components/blocks/QuoteBlockRenderer";
export { DividerBlockRenderer } from "./components/blocks/DividerBlockRenderer";
export { ToDoBlockRenderer } from "./components/blocks/ToDoBlockRenderer";
Expand All @@ -20,3 +21,6 @@ export { OrderedListBlockRenderer } from "./components/blocks/OrderedListBlockRe
// Export types
export type { BlockComponents } from "./components/BlockRenderer";
export type { JsonDocRendererProps, BlockRendererProps } from "./types";

// Import default styles - users can override by importing their own after this
import "./styles/index.css";
Loading
Loading