Skip to content

Rich text in bulleted list fix #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions .github/workflows/preview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
name: Publish preview from PR
on:
pull_request:
paths:
- 'typescript/**'
- '!typescript/**/*.md' # Exclude markdown files using ! prefix
- '!typescript/README.md'

jobs:
publish-to-pkg-pr:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies
working-directory: ./typescript
run: npm ci

- name: Generate types and build package
working-directory: ./typescript
run: |
npm run generate-types
npm run build

- name: Run tests
working-directory: ./typescript
run: npm test

- name: Prepare package for publishing
working-directory: ./typescript
run: |
npm pack



- name: List files in typescript dir
working-directory: ./typescript
run: |
ls -la

- name: Create git symlink
run: ln -s ../.git typescript/.git

# - name: Mv tgz to root
# working-directory: ./typescript
# run: |
# mv *.tgz ../

- name: List files in root
run: |
ls -la

- name: Publish preview
working-directory: ./typescript
run: npx pkg-pr-new publish
6 changes: 3 additions & 3 deletions typescript/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -254,15 +254,15 @@ MIT
- [x] table
- [ ] todo?
- [x] equation
- [ ] image
- [x] image
- [x] blockquote
- [] fix ts and eslint errors in these dirs and remove from ignore list of ts and eslint
```
"**/generated/**",
"src/serialization/**",
```
- [x] add counter for numbered lists
- [] setup up bumpp: https://www.npmjs.com/package/bumpp
- [x] setup up bumpp: https://www.npmjs.com/package/bumpp
- [] migrate test runner to vitest
- [] move vite app to typescript root examples dir
- [x] move vite app to typescript root examples dir
- [] setup monorepo tooling
16 changes: 8 additions & 8 deletions typescript/examples/vite_basic/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,31 +24,31 @@ export default tseslint.config({
languageOptions: {
// other options...
parserOptions: {
project: ['./tsconfig.node.json', './tsconfig.app.json'],
project: ["./tsconfig.node.json", "./tsconfig.app.json"],
tsconfigRootDir: import.meta.dirname,
},
},
})
});
```

You can also install [eslint-plugin-react-x](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-x) and [eslint-plugin-react-dom](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-dom) for React-specific lint rules:

```js
// eslint.config.js
import reactX from 'eslint-plugin-react-x'
import reactDom from 'eslint-plugin-react-dom'
import reactX from "eslint-plugin-react-x";
import reactDom from "eslint-plugin-react-dom";

export default tseslint.config({
plugins: {
// Add the react-x and react-dom plugins
'react-x': reactX,
'react-dom': reactDom,
"react-x": reactX,
"react-dom": reactDom,
},
rules: {
// other rules...
// Enable its recommended typescript rules
...reactX.configs['recommended-typescript'].rules,
...reactX.configs["recommended-typescript"].rules,
...reactDom.configs.recommended.rules,
},
})
});
```
26 changes: 13 additions & 13 deletions typescript/examples/vite_basic/eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
import js from '@eslint/js'
import globals from 'globals'
import reactHooks from 'eslint-plugin-react-hooks'
import reactRefresh from 'eslint-plugin-react-refresh'
import tseslint from 'typescript-eslint'
import js from "@eslint/js";
import globals from "globals";
import reactHooks from "eslint-plugin-react-hooks";
import reactRefresh from "eslint-plugin-react-refresh";
import tseslint from "typescript-eslint";

export default tseslint.config(
{ ignores: ['dist'] },
{ ignores: ["dist"] },
{
extends: [js.configs.recommended, ...tseslint.configs.recommended],
files: ['**/*.{ts,tsx}'],
files: ["**/*.{ts,tsx}"],
languageOptions: {
ecmaVersion: 2020,
globals: globals.browser,
},
plugins: {
'react-hooks': reactHooks,
'react-refresh': reactRefresh,
"react-hooks": reactHooks,
"react-refresh": reactRefresh,
},
rules: {
...reactHooks.configs.recommended.rules,
'react-refresh/only-export-components': [
'warn',
"react-refresh/only-export-components": [
"warn",
{ allowConstantExport: true },
],
},
},
)
}
);
4 changes: 2 additions & 2 deletions typescript/examples/vite_basic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"dev": "vite",
"dev": "vite --clearScreen false",
"build": "tsc -b && vite build",
"lint": "eslint .",
"preview": "vite preview",
"preinstall": "npx only-allow pnpm"
},
"dependencies": {
"@textcortex/jsondoc": "0.2.0-alpha.1",
"@textcortex/jsondoc": "link:/Users/abrehamgezahegn/Documents/projects/textcortex/JSON-DOC/typescript",
"react": "^19.1.0",
"react-dom": "^19.1.0"
},
Expand Down
Loading
Loading