feat(rule): "には" を 一つの助詞として認識するように #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
commented
Mar 4, 2017
| * } | ||
| * @param tokens | ||
| * @returns {*} | ||
| */ | ||
| function createSurfaceKeyMap(tokens) { | ||
| // 助詞のみを対象とする | ||
| return tokens.filter(is助詞Token).reduce((keyMap, token) => { |
There was a problem hiding this comment.
ここはいらなかった。 tokensには助詞tokensのみしかこない
src/no-doubled-joshi.js
Outdated
| const tokens = tokenizer.tokenizeForSentence(sentence.raw); | ||
| // 助詞 + 助詞は 一つの助詞として扱う | ||
| // https://github.com/textlint-ja/textlint-rule-no-doubled-joshi/issues/15 | ||
| const concatTokens = concatJoishiTokens(tokens); |
|
もう何種類かテストケース欲しい |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今までは
は に と は という2つの助詞として認識していた。(理論的には正しい)
けど、これにより
というケースも に という助詞が連続している事になっていた
close #15