WIP/RFC possible use of va_list in gencode.c #1520
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another unfinished piece that didn't quite work out the way I originally expected, but took some time to produce anyway. Potentially this could be developed further, please have a look when you have time.
This is one of the optimizations that avoid generating duplicate instructions in the first place. On this occasion it is the code produced by a series of ORed
gen_cmp()
calls, all of which load the same exact packet data, in which case, obviously, only the first load is required. The draft demonstrates how this can be done for PPP, ATM and ARCnet (the tests pass), all of which hard-code the values.