Skip to content

Add symfony cache dir to graphqlite file adapter service #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cvergne
Copy link
Contributor

@cvergne cvergne commented Sep 8, 2023

Hello,

By investigating some permissions issues on graphqlite cache files, I've noticed that graphqlite-bundle cache files are properly set in Symfony cache folder since this PR, but graphqlite cache files are still in tmp folder because of the service configuration :

<service id="graphqlite.phpfilescache" class="Symfony\Component\Cache\Adapter\PhpFilesAdapter">
<argument>graphqlite</argument>
</service>

As no value is provided for the directory argument of the adapter, the tmp directory is used (with a symfony-cache folder created inside).

So this PR is to apply the same change (kind of) of the previous PR but for the graphqlite related cache service.

@homersimpsons homersimpsons merged commit b2bc994 into thecodingmachine:master Sep 8, 2023
@homersimpsons
Copy link
Collaborator

Thank you for this 🎉 Released as v6.0.3

@cvergne cvergne deleted the fix/graphqlite-symfony-cache-folder branch September 8, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants