Skip to content

[Error handling] Remove category from exceptions #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Controller/GraphQL/InvalidUserPasswordException.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ class InvalidUserPasswordException extends GraphQLException
{
public static function create(Exception $previous = null): self
{
return new self('The provided user / password is incorrect.', 401, $previous, 'Security');
return new self('The provided user / password is incorrect.', 401, $previous);
}
}
2 changes: 1 addition & 1 deletion Tests/Fixtures/Controller/TestGraphqlController.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function triggerException(int $code = 0): string
public function triggerAggregateException(): string
{
$exception1 = new GraphQLException('foo', 401);
$exception2 = new GraphQLException('bar', 404, null, 'MyCat', ['field' => 'baz', 'category' => 'MyCat']);
$exception2 = new GraphQLException('bar', 404, null, ['field' => 'baz']);
throw new GraphQLAggregateException([$exception1, $exception2]);
}

Expand Down
2 changes: 0 additions & 2 deletions Tests/FunctionalTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ public function testExceptionHandler(): void

$this->assertSame('foo', $result['errors'][0]['message']);
$this->assertSame('bar', $result['errors'][1]['message']);
$this->assertSame('MyCat', $result['errors'][1]['extensions']['category']);
$this->assertSame('baz', $result['errors'][1]['extensions']['field']);
}

Expand Down Expand Up @@ -463,7 +462,6 @@ public function testValidation(): void

$this->assertSame('This value is not a valid email address.', $errors[0]['message']);
$this->assertSame('email', $errors[0]['extensions']['field']);
$this->assertSame('Validate', $errors[0]['extensions']['category']);
}

public function testWithIntrospection(): void
Expand Down
Loading