Skip to content

Command to dump schema #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

TamasSzigeti
Copy link
Contributor

@TamasSzigeti TamasSzigeti commented Jun 19, 2021

Adding a command to dump schema for using with apollo codegen for example.
Sorting queries by name to have consistency and be able to rely on this in CI for example

This issue should be move to this repo
thecodingmachine/graphqlite#352

@TamasSzigeti
Copy link
Contributor Author

@moufmouf @devmaslov Please review

@TamasSzigeti
Copy link
Contributor Author

@moufmouf @devmaslov Any plans to add github CI for this repo? I could do it in another PR, there are some failures already (unrelated to this pr)…

@moufmouf
Copy link
Member

We would definitely envoyé hacking this répond migrantes to Gitlab CI! +1 for another PR if you can!

@moufmouf
Copy link
Member

We would definitely envoyé hacking this répond migrantes to Gitlab CI! +1 for another PR if you can!

Lol just read my message sent from a phone in a hurry. Damn autocorrect!

I meant:

"We would definitely love having this repo migrated to Gitlab CI! +1 for another PR if you can!"

And so, thanks a lot for #94 .

I read your PR and have no special comment. 👍 for me for merging this.

@TamasSzigeti If you are ok, we could first merge #94 (when it is ready) and then merge this PR (when CI passes?)

Thanks a lot for this PR, it will prove to be very useful!

@TamasSzigeti
Copy link
Contributor Author

No worries, other than gitlab vs github I wasn't even confused that much (:

Yes I'm fine with finishing the CI first I just want to see it running, as it will surely fail – I've seen some issues with dependencies. Maybe let's merge the yaml as it is after review, allow it to fail in master, and then I create a third PR to fix the failures? I'm not sure if github would ever allow running contributed workflows from fork PRs…?

@TamasSzigeti
Copy link
Contributor Author

TamasSzigeti commented Jun 21, 2021

Then possibly a fourth PR addressing the stan errors that for now I've put into a baseline

@TamasSzigeti TamasSzigeti force-pushed the dump-schema-command branch from 8709434 to f0c0502 Compare June 22, 2021 08:08
@moufmouf
Copy link
Member

Thanks a lot!

@moufmouf moufmouf merged commit 3afc2ee into thecodingmachine:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants