Fixes PSR4 auto-loading and code style issues #98
Conversation
…ema command + Fixes code styling in the same test class + Replaces the deprecated assertion with the recommended one + Installs phpunit library + Fixes schema location path in phpunit xml + Adds a composer.lock file + Removes composer.lock file from .gitignore file
composer.json
Outdated
| @@ -41,7 +41,8 @@ | |||
| "symfony/phpunit-bridge": "^5.3", | |||
| "thecodingmachine/phpstan-strict-rules": "^v0.12.1", | |||
| "composer/package-versions-deprecated": "^1.8", | |||
| "phpstan/phpstan-webmozart-assert": "^0.12.12" | |||
| "phpstan/phpstan-webmozart-assert": "^0.12.12", | |||
| "phpunit/phpunit": "^9.5" | |||
There was a problem hiding this comment.
Why is this necessary? I removed it because we already have symfony phpunit bridge
There was a problem hiding this comment.
Hmm yeah. I couldn't find any contributing guide and overlooked this.
Reverted it now. though I wonder what benefit is the said package of here?
.gitignore
Outdated
| @@ -1,5 +1,4 @@ | |||
| /vendor/ | |||
| /composer.lock | |||
There was a problem hiding this comment.
Why would we want a lock file? Generally library dependencies are not to be locked
| /** | ||
| * @test | ||
| */ | ||
| public function it_executes_successfully(): void |
There was a problem hiding this comment.
Why? That looks like phpspec style, not what is generally used in phpunit
There was a problem hiding this comment.
This is a recommended practice to name your tests to make them descriptive and indicative of what tests are doing.
I don't think this is something specific to phpspec.
There was a problem hiding this comment.
Okay, let's say it's a matter of taste. This project, along with the graphqlite package doesn't use this syntax, and I don't see any point in changing it, especially if you change only a single test method.
|
Any possibility for this getting processed? |
?? |
|
Can this be merged? |
|
Looks good, let's merge it! |
Uh oh!
There was an error while loading. Please reload this page.