Support safe ^2.0

[dbrekelmans]

No description provided.

[nealio82]

WEN MERGE? 😢

[dbrekelmans]

@moufmouf Could you take a look when you have time? I'm only a maintainer on the safe repo, not on this one :)

[Jean85]

Just updated to this alongside safe 2.0.2, it seems to work.

[akondas]

release? 🙏

[dbrekelmans]

I've created a release on my fork for anyone to use until this PR is merged:

• https://github.com/dbrekelmans/phpstan-safe-rule/releases/tag/v1.2.0
• https://packagist.org/packages/dbrekelmans/phpstan-safe-rule

If you use this, please take into consideration that I will abandon/remove the fork as soon as this PR is merged.

[webard]

@dbrekelmans you have error in your fork in FunctionsListLoader.php, method should getFunctionList be:

 public static function getFunctionList(): array
    {
        if (self::$functions === null) {
            if (\file_exists(__DIR__.'/../../../safe/generated/functionsList.php')) {
                $functions = require __DIR__.'/../../../safe/generated/functionsList.php';
            } elseif (\file_exists(__DIR__.'/../../../../../vendor/thecodingmachine/safe/generated/functionsList.php')) {
                $functions = require __DIR__.'/../../../../../vendor/thecodingmachine/safe/generated/functionsList.php';
            } else {
                throw new \RuntimeException('Could not find thecodingmachine/safe\'s functionsList.php file.');
            }
            // Let's index these functions by their name
            self::$functions = \Safe\array_combine($functions, $functions);
        }
        return self::$functions;
    }

[dbrekelmans]

@webard I'm not sure what you mean... I didn't change anything in my fork except for merging this PR.

https://github.com/dbrekelmans/phpstan-safe-rule/blob/v1.2.0/src/Utils/FunctionListLoader.php

[webard]

@dbrekelmans thecodingmachine/safe and thecodingmachine/phpstan-safe-rule are in same directory. in vendor. Your package is in dbrekelmans/phpstan-safe-rule, so you need change path relativity in function getFunctionList.

[dbrekelmans]

@webard Ah I see what you mean, thanks for the heads up. I don't have time to fix it myself today, but if you are willing to create a PR, I can merge and release it

[moufmouf]

Hey @dbrekelmans,

I'm really sorry I only see this now.
Of course, if you are maintainer on Safe you also need to be maintainer on this package. I added you as a maintainer right now.

[dbrekelmans]

No problem @moufmouf, thanks for adding me as a maintainer!