Type hints for Safe\preg_match, fixes #40 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
=============================================
- Coverage 92.13% 75.92% -16.21%
- Complexity 33 41 +8
=============================================
Files 7 8 +1
Lines 89 108 +19
=============================================
Hits 82 82
- Misses 7 26 +19 ☔ View full report in Codecov by Sentry. |
shish
changed the title
OskarStark
reviewed
Feb 9, 2025
|
|
||
| class PregMatchParameterOutTypeExtensionTest extends TypeInferenceTestCase | ||
| { | ||
|
|
There was a problem hiding this comment.
This should be fixed by php-cs-fixer
There was a problem hiding this comment.
Looks like tests/ aren't covered by the formatter - I'll manually fix for now, and then cover tests in a follow-up
shish
force-pushed
the
pr43
branch
3 times, most recently
from
66036d5 to
b2a8a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.