Skip to content

Add openssl_pkey_get_details function missing in PHP < 8.4 #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cedric-anne
Copy link
Contributor

The openssl_pkey_get_details() function is not generated in PHP < 8.4.

I hope adding it in this file will make it available for all PHP versions.

trasher added a commit to trasher/glpi that referenced this pull request May 13, 2025
@cedric-anne cedric-anne force-pushed the fix/openssl_pkey_get_details branch from b5a8114 to ecbc1de Compare May 13, 2025 08:01
@OskarStark OskarStark requested a review from shish May 13, 2025 09:17
@shish
Copy link
Collaborator

shish commented May 13, 2025

Thank you for checking <3 This looks like it wasn't detected in php <8.4 because of a typo in the older versions of the docs -- I'd rather pick up that typo when it happens (which fixes behaviour for 8.1-8.3) than add a function to special_cases.php (which overrides behaviour for all versions, including future ones) - done in #663

@cedric-anne
Copy link
Contributor Author

Thank you for checking <3 This looks like it wasn't detected in php <8.4 because of a typo in the older versions of the docs -- I'd rather pick up that typo when it happens (which fixes behaviour for 8.1-8.3) than add a function to special_cases.php (which overrides behaviour for all versions, including future ones) - done in #663

Now I understand how the code is generated and I may propose some other fixes. Indeed, in our codebase, we have 300+ errors detected in PHP 8.2 but not in PHP 8.4. If they are related to an undetected pattern in the doc, now I know how to solve this.

Thanks for your quick review/fix.

@cedric-anne cedric-anne deleted the fix/openssl_pkey_get_details branch May 13, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants