Skip to content

Ignore the already safe imagesx()/imagesy() functions #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

cedric-anne
Copy link
Contributor

Since PHP 8.0, these functions are throwing TypeError when the first argument is not a GdImage instance. See php/doc-en@0462f49 and php/doc-en@37f858a.

Copy link
Collaborator

@silasjoisten silasjoisten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@silasjoisten silasjoisten merged commit 554aeeb into thecodingmachine:master May 13, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/imagesx-y branch May 13, 2025 14:20
@silasjoisten
Copy link
Collaborator

silasjoisten commented May 13, 2025

released in v3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants