Skip to content

added check for float and double using if-statements #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2018
Merged

added check for float and double using if-statements #23

merged 3 commits into from
Mar 12, 2018

Conversation

bryantam
Copy link

@bryantam bryantam commented Mar 6, 2018

by comparing pointers to fltSemantics, and convert them to double/float

@bryantam
added check for float and double
dbcbe3a 
comparing pointers to fltSemantics
@bryantam bryantam requested review from mmroz and aoli-al March 6, 2018 18:55
aoli-al
aoli-al reviewed Mar 9, 2018
View reviewed changes
Copy link

@aoli-al aoli-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to use convertToDouble and convertToFloat to avoid converting APFloat manually.

aoli-al
aoli-al approved these changes Mar 11, 2018
View reviewed changes
Copy link

@aoli-al aoli-al left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantam bryantam merged commit eb862aa into themaplelab:wala-feature/FloatLiterals Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoli-al aoli-al aoli-al approved these changes

@mmroz mmroz Awaiting requested review from mmroz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantam @aoli-al