Skip to content

Fix autoloader fatal errors from class reorganization #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

MegaphoneJon
Copy link
Contributor

This is intended to fix some autoloader issues I experienced regarding the recent reorganization. Ping @eileenmcnaughton.

@eileenmcnaughton
Copy link
Contributor

This looks like a bug I introduced when adding those new actions. In response to reviewer feedback I moved the files into a subdirectory ('Query') but did not update this place in the code to reflect that. I think this should be merged

@barryvdh barryvdh merged commit 59fa792 into thephpleague:master Dec 20, 2017
@judgej
Copy link
Member

judgej commented Dec 20, 2017

Thanks Barry, was just about to look at this.

As an aside, instead of '\Omnipay\AuthorizeNet\Message\Query\QueryRequest' I tend now to use the \Omnipay\AuthorizeNet\Message\Query\QueryRequest::class form, which can usually be shortened by context in the file it's used in to something like Message\Query\QueryRequest::class. There aren't any downsides in doing this, are there? Using the ::class modifier gives the fully qualified class name, but without the leading \, which works fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants