Change items parameter to a string #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonvarga this PR is breaking tests. Can you update the tests to work with the new structure? |
|
Sorry about that. There we go! |
|
+1! |
greydnls
added a commit
that referenced
this pull request
Jan 14, 2015
Change items parameter to a string
|
Just tagged 2.2.0 with these changes. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a purchase request with line items – which is an array – you get
SimpleXMLElement::addChild() expects parameter 2 to be string, array given.The MultiSafepay docs request a string, and their code examples suggest to construct a
ul.The
uldisplays nicely in their checkout process and in their emails.