[Bugfix] Use .requires_grad
instead of .require_grad
in embedding module
#743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug / typo in
layers/Embed.py
on lines 13 and 50.Torch tensors do not have an attribute called
require_grad
, and thereforepe.require_grad = False
andw.require_grad = False
calls were resulting in the insertion of an additionalrequire_grad
attribute to the instantiated tensor, that did nothing.The correct attribute to track gradients is Torch is called
requires_grad
, and in this PR both lines (13 and 50) are changed to reflect this.The existing bug / typo is not expected to have affected any code behavior, as when a tensor is created using
torch.zeros
, it by default comes withrequires_grad
attribute set toFalse
anyways. But for the sake of clarity and preventing any future confusion it is worthwhile to fix the bug anyways.