use rlang::is_call_simple (#746)

* use rlang::is_call_simple

* add test

* update news

* Update NEWS.md

Co-authored-by: Davis Vaughan <[email protected]>

Co-authored-by: Davis Vaughan <[email protected]>
Co-authored-by: Max Kuhn <[email protected]>

Author: 3 people

NEWS.md

@@ -23,6 +23,8 @@
 
 * Model type functions will now message informatively if a needed parsnip extension package is not loaded (#731).
 
+* Fixed a bug where an error would be thrown if arguments to model functions were namespaced (#745).
+
 * Refactored internals of model specification printing functions. These changes are non-breaking for extension packages, but the new `print_model_spec()` helper is exported for use in extensions if desired (#739).
 
 

R/tune_args.R

@@ -102,7 +102,7 @@ tune_id <- function(x) {
 
     # [tune()] will always return a call object
     if (is.call(x)) {
-      if (rlang::call_name(x) == "tune") {
+      if (rlang::is_call_simple(x) && rlang::call_name(x) == "tune") {
         # If an id was specified:
         if (length(x) > 1) {
           return(x[[2]])

tests/testthat/test_extract.R

@@ -80,3 +80,17 @@ test_that('extract single parameter from model with main and engine parameters',
     NA
   )
 })
+
+test_that("extract_parameter_dials doesn't error if namespaced args are used", {
+  skip_on_covr()
+  skip_if(tune_check())
+
+  bst_model <-
+    logistic_reg(mode = "classification", penalty = hardhat::tune()) %>%
+      set_engine("glmnet", family = stats::gaussian("log"))
+
+  expect_error(
+    extract_parameter_dials(bst_model, parameter = "penalty"),
+    NA
+  )
+})