use rlang::is_call_simple

[EmilHvitfeldt]

This PR aims to close #745.

Before, what used to happen when a namespaced call came in, rlang::call_name(x) would return NULL and the if statement would break. This is happening because bar::foo is a complex name, see rlang::call_name().

library(parsnip)

glm_model_ns <- linear_reg() %>%
  set_engine("glm", family = stats::gaussian(tune("hello")))

glm_model_ns$eng_args
#> <list_of<quosure>>
#> 
#> $family
#> <quosure>
#> expr: ^stats::gaussian(tune("hello"))
#> env:  0x1177b49c8

parsnip:::find_tune_id(glm_model_ns$eng_args[[1]])
#> [1] "hello"

sg_call <- rlang::expr(stats::gaussian)

is.call(sg_call)
#> [1] TRUE

rlang::call_name(sg_call)
#> NULL

rlang::is_call_simple(sg_call)
#> [1] FALSE

This change doesn't break anything (that I found) by running extratests. It works even if tune() is namespaced

library(parsnip)

glm_model_ns <- linear_reg() %>%
  set_engine("glm", family = stats::gaussian(tune::tune("hello")))

parsnip:::find_tune_id(glm_model_ns$eng_args[[1]])
#> [1] "hello"

^{Created on 2022-06-03 by the reprex package (v2.0.1)}

[DavisVaughan]

Makes sense to me after reading the call_name() docs. Seems smart to guard those calls with is_call_simple() if you need to require that the result is a single TRUE/FALSE, as we do here

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.