Skip to content

remove registrations for engine arguments #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024
Merged

remove registrations for engine arguments #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1acf3fb
remove registrations for engine arguments
simonpcouch Jan 18, 2024
2c07ed5
update NEWS entry
simonpcouch Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

* Fixed bug in fitting some model types with the `"spark"` engine (#1045).

* Fixed issue in `mlp()` metadata where the `stop_iter` engine argument had been mistakenly protected for the `"brulee"` engine. (#1050)
* Fixed issues in metadata for the `"brulee"` engine where several arguments were mistakenly protected. (#1050, #1054)

* `.filter_eval_time()` was moved to the survival standalone file.

Expand Down
38 changes: 0 additions & 38 deletions R/linear_reg_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,44 +540,6 @@ set_model_arg(
has_submodel = FALSE
)

set_model_arg(
model = "linear_reg",
eng = "brulee",
parsnip = "epochs",
original = "epochs",
func = list(pkg = "dials", fun = "epochs"),
has_submodel = FALSE
)

set_model_arg(
model = "linear_reg",
eng = "brulee",
parsnip = "learn_rate",
original = "learn_rate",
func = list(pkg = "dials", fun = "learn_rate"),
has_submodel = FALSE
)

set_model_arg(
model = "linear_reg",
eng = "brulee",
parsnip = "momentum",
original = "momentum",
func = list(pkg = "dials", fun = "momentum"),
has_submodel = FALSE
)


set_model_arg(
model = "linear_reg",
eng = "brulee",
parsnip = "stop_iter",
original = "stop_iter",
func = list(pkg = "dials", fun = "stop_iter"),
has_submodel = FALSE
)


set_fit(
model = "linear_reg",
eng = "brulee",
Expand Down
38 changes: 0 additions & 38 deletions R/logistic_reg_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,44 +673,6 @@ set_model_arg(
has_submodel = FALSE
)


set_model_arg(
model = "logistic_reg",
eng = "brulee",
parsnip = "epochs",
original = "epochs",
func = list(pkg = "dials", fun = "epochs"),
has_submodel = FALSE
)

set_model_arg(
model = "logistic_reg",
eng = "brulee",
parsnip = "learn_rate",
original = "learn_rate",
func = list(pkg = "dials", fun = "learn_rate"),
has_submodel = FALSE
)

set_model_arg(
model = "logistic_reg",
eng = "brulee",
parsnip = "momentum",
original = "momentum",
func = list(pkg = "dials", fun = "momentum"),
has_submodel = FALSE
)


set_model_arg(
model = "logistic_reg",
eng = "brulee",
parsnip = "stop_iter",
original = "stop_iter",
func = list(pkg = "dials", fun = "stop_iter"),
has_submodel = FALSE
)

set_fit(
model = "logistic_reg",
eng = "brulee",
Expand Down
18 changes: 0 additions & 18 deletions R/mlp_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,15 +388,6 @@ set_model_arg(
has_submodel = FALSE
)

set_model_arg(
model = "mlp",
eng = "brulee",
parsnip = "mixture",
original = "mixture",
func = list(pkg = "dials", fun = "mixture"),
has_submodel = FALSE
)

set_model_arg(
model = "mlp",
eng = "brulee",
Expand Down Expand Up @@ -424,15 +415,6 @@ set_model_arg(
has_submodel = FALSE
)

set_model_arg(
model = "mlp",
eng = "brulee",
parsnip = "momentum",
original = "momentum",
func = list(pkg = "dials", fun = "momentum"),
has_submodel = FALSE
)

set_model_arg(
model = "mlp",
eng = "brulee",
Expand Down
37 changes: 0 additions & 37 deletions R/multinom_reg_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,43 +379,6 @@ set_model_arg(
has_submodel = FALSE
)

set_model_arg(
model = "multinom_reg",
eng = "brulee",
parsnip = "epochs",
original = "epochs",
func = list(pkg = "dials", fun = "epochs"),
has_submodel = FALSE
)

set_model_arg(
model = "multinom_reg",
eng = "brulee",
parsnip = "learn_rate",
original = "learn_rate",
func = list(pkg = "dials", fun = "learn_rate"),
has_submodel = FALSE
)

set_model_arg(
model = "multinom_reg",
eng = "brulee",
parsnip = "momentum",
original = "momentum",
func = list(pkg = "dials", fun = "momentum"),
has_submodel = FALSE
)


set_model_arg(
model = "multinom_reg",
eng = "brulee",
parsnip = "stop_iter",
original = "stop_iter",
func = list(pkg = "dials", fun = "stop_iter"),
has_submodel = FALSE
)

set_fit(
model = "multinom_reg",
eng = "brulee",
Expand Down