Skip to content

updated rlang messages in the predict functions to use cli. #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

shum461
Copy link
Contributor

@shum461 shum461 commented Aug 15, 2024

Fixes #1138

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start!

Also, please feel free to credit yourself in the package NEWS!

@simonpcouch
Copy link
Contributor

Thanks for the PR, @shum461! Are you interested in making the changes suggested in review or would you like us to take it from here?

@simonpcouch simonpcouch merged commit 146bd6b into tidymodels:main Aug 28, 2024
10 checks passed
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cli errors in R/predict.R
2 participants