Skip to content

Compute and print time elapsed #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 1, 2019
Merged

Conversation

patr1ckm
Copy link
Contributor

This computes and prints the elapsed time when fitting the model for both fit_xy and fit.

Fixes #175 .

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #224 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   75.81%   75.98%   +0.17%     
==========================================
  Files          38       38              
  Lines        2931     2936       +5     
==========================================
+ Hits         2222     2231       +9     
+ Misses        709      705       -4
Impacted Files Coverage Δ
R/fit.R 81.81% <100%> (+2.73%) ⬆️
R/fit_helpers.R 96.55% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fef9c3...582def3. Read the comment docs.

@topepo
Copy link
Member

topepo commented Nov 1, 2019

Can you use system.time() instead? Also, use the prettyunits package to print the total elapsed time.

@patr1ckm
Copy link
Contributor Author

patr1ckm commented Nov 1, 2019

prettyunits is great, thanks! Here's how it looks:

Screen Shot 2019-11-01 at 10 45 17 AM

@topepo
Copy link
Member

topepo commented Nov 1, 2019

Excellent. Thanks

@topepo topepo merged commit 3a6d11f into tidymodels:master Nov 1, 2019
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a elapsed time slot for fitted models
3 participants