Skip to content

update vignette "Making a parsnip model from scratch" #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Dec 16, 2019

fixed the step numbers and a few more typos

also noticed that the pkgdown site still shows the typo from PR #233

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #248   +/-   ##
=====================================
  Coverage      71%    71%           
=====================================
  Files          38     38           
  Lines        3001   3001           
=====================================
  Hits         2131   2131           
  Misses        870    870
Impacted Files Coverage Δ
R/aaa_models.R 91.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e5d3fa...fb6535a. Read the comment docs.

@topepo topepo merged commit 56e8b7c into tidymodels:master Jan 31, 2020
@topepo
Copy link
Member

topepo commented Jan 31, 2020

Thanks!

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants