Write out iris with modeldata::hpc_data #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching out iris for modeldata::hpc_data—much of the switches so far were global find-and-replace, with some manual bug fixes. Still quite a few to go.
simonpcouch
changed the title
There are 4 factor levels in hpc_data$class, but 3 in iris$Species, which tripped up a few tests.
Addresses some failures re: some subsetting by name and some by index
The fourth factor level in hpc_data was preserved in some tests. Also, some manually entered predictions needed to be rewritten.
Some more manual data entry and # classes in outcome variable issues.
Initially switched from iris to mtcars, but the Orange data is a bit more interesting / illustrative.
|
Okay, I think this is good to go! Let me know if the Worth mentioning that |
Merged
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few of the changes so far were global find-and-replace, with some manual bug fixes. Still quite a few to go—will come back to this over the weekend.