Skip to content

Add MacOS testing back to parsnip #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 1, 2020
Merged

Add MacOS testing back to parsnip #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d0faf02
Add MacOS testing back to parsnip
juliasilge Jun 29, 2020
ca3681e
Use Windows 3.6 instead of oldrel
juliasilge Jun 29, 2020
d1ce373
Set Miniconda path for macOS
juliasilge Jun 30, 2020
c7cacc0
Create Miniconda separately for not Windows vs. Windows
juliasilge Jun 30, 2020
0a6ec85
TensorFlow needs the conda env as well, naturally
juliasilge Jun 30, 2020
75ee6d3
Set miniconda env variable in matrix
juliasilge Jun 30, 2020
5ed3999
Revert
juliasilge Jun 30, 2020
3d5e177
Try one directory level up for Miniconda
juliasilge Jun 30, 2020
f774b67
Update location on conda environment
juliasilge Jun 30, 2020
ed046f5
Set conda path for whole workflow, for macOS
juliasilge Jun 30, 2020
dbb0afc
Put Miniconda path into config matrix
juliasilge Jun 30, 2020
cbcb918
Merge branch 'master' into update-gh-actions
juliasilge Jun 30, 2020
2198fab
Move Miniconda env out of config
juliasilge Jun 30, 2020
c8b3ac1
Add separate step for reticulate to prefer the Miniconda environment
juliasilge Jun 30, 2020
3c9dfc2
Use option for reticulate to always prefer the Miniconda environment
juliasilge Jun 30, 2020
bc2fd34
reverted test `on:` specification
topepo Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions .github/workflows/R-CMD-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ jobs:
fail-fast: false
matrix:
config:
- { os: windows-latest, r: '3.6'}
- { os: windows-latest, r: '4.0'}
- { os: windows-latest, r: 'devel'}
- { os: ubuntu-16.04, r: '3.5', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- { os: ubuntu-16.04, r: '3.6', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest"}
- {os: macOS-latest, r: 'devel'}
- {os: macOS-latest, r: 'release'}
- {os: windows-latest, r: 'release'}
- {os: windows-latest, r: '3.6'}
- {os: ubuntu-16.04, r: 'release', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: 'oldrel', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.5', rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
Expand Down Expand Up @@ -65,11 +67,20 @@ jobs:
remotes::install_cran("rcmdcheck")
shell: Rscript {0}

- name: Install TensorFlow
- name: Install Miniconda
run: |
Rscript -e "remotes::install_github('rstudio/reticulate')"
Rscript -e "reticulate::install_miniconda()"
Rscript -e "reticulate::conda_create('r-reticulate', packages = 'python==3.6.9')"
Rscript -e "tensorflow::install_tensorflow(version='1.14.0')"

- name: Find Miniconda on macOS
if: runner.os == 'macOS'
run: echo "options(reticulate.conda_binary = reticulate:::miniconda_conda())" >> .Rprofile

- name: Install TensorFlow
run: |
reticulate::conda_create('r-reticulate', packages = c('python==3.6.9'))
tensorflow::install_tensorflow(version='1.14.0')
shell: Rscript {0}

- name: Session info
run: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-coverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ jobs:

- name: Install TensorFlow
run: |
Rscript -e "remotes::install_github('rstudio/reticulate')"
Rscript -e "reticulate::install_miniconda()"
echo "options(reticulate.conda_binary = reticulate:::miniconda_conda())" >> .Rprofile
Rscript -e "reticulate::conda_create('r-reticulate', packages = 'python==3.6.9')"
Rscript -e "tensorflow::install_tensorflow(version='1.14.0')"

Expand Down