Improve errors for set_mode()
and set_engine()
#488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426
This PR makes our handling of a missing argument and a bad argument a bit more consistent for
set_mode()
andset_engine()
. There was some handling coded up in both cases but we weren't really getting those benefits for missing (or evenNULL
) inputs before. This rearranging should make help things out.The already existing warning/replacement for engines now works:
Created on 2021-05-11 by the reprex package (v2.0.0)
For mode, I just set this up to tell the user their options:
Created on 2021-05-11 by the reprex package (v2.0.0)
I did need to adjust some tests, switching between errors and warnings, but I don't think any of that is substantive.