Skip to content

Update documentation of survival models to new doc style #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2021
Merged

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Oct 24, 2021

This PR updates the documentation for the following survival models to the new style with engine-specific pages

  • surv_reg()
  • survival_reg()
  • proportional_hazards()

I've also updated the docs for soft-deprecated surv_reg() because this is likely to still get used until survival_reg() is fully functional - the engines are in censored which is not on CRAN yet.

Where do we put the info about flipped sign for the linear predictor? Currently, it is on the man page for predict() which I think is the right place, rather than a man page on the model specification.

@hfrick hfrick requested a review from topepo October 24, 2021 16:50
@topepo topepo merged commit 42a5707 into main Nov 1, 2021
@topepo topepo deleted the doc-survival branch November 1, 2021 20:01
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants