Skip to content

move methods for tunable() from tune to parsnip #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2021
Merged

move methods for tunable() from tune to parsnip #606

merged 4 commits into from
Nov 24, 2021

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Nov 18, 2021

This PR is part of moving methods for tunable() from tune to the package which holds the corresponding object class:

When methods have been moved, the methods are registered conditionally on the version of tune from which they have been removed. The tune PR is tidymodels/tune#433

The tests require multiple packages so they are all in extratests: tidymodels/extratests#34

The PR on extratests should be merged first, then the ones on recipes and parsnip, then workflows, then tune.

This is part of the wider aim of introducing extract_parameter_dials() and extract_parameter_set_dials() and the next steps are:

  • introducing extract_parameter_set_dials()
  • introducing extract_parameter_dials()
  • moving the methods for parameters() similar to this PR set
  • updating documentation and learning materials

@hfrick hfrick merged commit 3c88e50 into main Nov 24, 2021
@hfrick hfrick deleted the tunable branch November 24, 2021 17:11
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants