Skip to content

Updates to execution time collection #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Updates to execution time collection #614

merged 2 commits into from
Nov 30, 2021

Conversation

topepo
Copy link
Member

@topepo topepo commented Nov 30, 2021

Closes #611

@topepo topepo requested a review from juliasilge November 30, 2021 00:38
Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a really nice change. 🙌

It will effect quite a lot of output in the long term (tidymodels.org, our book, various READMEs in various packages) but I think we should just change those as they come up.

@EmilHvitfeldt
Copy link
Member

Would these changes be enough to handle #578 as well?

@juliasilge
Copy link
Member

Yep, also closes #578

@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to set gcFirst to FALSE in the internal calls to system.time in form_form and xy_xy
3 participants