fix cforest_train()
#711
Merged
fix cforest_train()
#711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
approved these changes
May 3, 2022
|
Yes, closes tidymodels/bonsai#9! # pak::pak("tidymodels/parsnip#711")
library(partykit)
#> Loading required package: grid
#> Loading required package: libcoin
#> Loading required package: mvtnorm
library(bonsai)
library(parsnip)
library(testthat)
set.seed(1)
cf_fit_1 <-
rand_forest(trees = 5) %>%
set_engine("partykit") %>%
set_mode("regression") %>%
fit(mpg ~ ., data = mtcars)
set.seed(1)
pk_fit_1 <- cforest(mpg ~ ., data = mtcars, ntree = 5)
expect_equal(pk_fit_1$fitted, cf_fit_1$fit$fitted)
cf_pred_1 <- predict(cf_fit_1, mtcars)$.pred
pk_pred_1 <- unname(predict(pk_fit_1, mtcars))
expect_equal(pk_pred_1, cf_pred_1)Created on 2022-05-03 by the reprex package (v2.0.1) Huzzah! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it didn't return the results of the evaluation in the environment with the weights which caused the cforests tests in censored to fail. Possibly also the reason for tidymodels/bonsai#9