Skip to content

add missing comment about usekernel in naive_Bayes naivebayes #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022

Conversation

EmilHvitfeldt
Copy link
Member

Missing documentation has been added to close #712.

@EmilHvitfeldt EmilHvitfeldt requested a review from topepo May 6, 2022 23:07
@juliasilge
Copy link
Member

I think this documentation is still confusing and sounds like usekernel cannot be changed. Instead, can we say it is an engine argument, with a default of TRUE?

@EmilHvitfeldt
Copy link
Member Author

I did a quick rewording, let me know what you think

@juliasilge
Copy link
Member

Yes, more clear now! 🙌

@EmilHvitfeldt EmilHvitfeldt merged commit 3871fd8 into main May 10, 2022
@EmilHvitfeldt EmilHvitfeldt deleted the naivebayes-usekernel-documentation branch May 10, 2022 20:13
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usekernel setting in Naive Bayes models with engine = "klaR"
2 participants