Skip to content

document elastic net regularization via mixture #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

simonpcouch
Copy link
Contributor

Closes #570. In my experience, "interpolate" is the verbiage here. :)

Will need someone else to generate documentation for me—spent a while trying to debug, and eventually came across a set of errors in knit_engine_docs:

Failed with error:  'package 'parsnip' required by 'censored' could not be found'
Failed with error:  'package 'parsnip' required by 'discrim' could not be found'
# etc etc

that's not worth me troubleshooting if others are able to follow inst/README-DOCS.md just fine.🛫

@simonpcouch simonpcouch requested a review from EmilHvitfeldt May 9, 2022 00:05
@topepo
Copy link
Member

topepo commented May 9, 2022

Try using parsnip:::install_engine_packages().

Where should we document this?

@simonpcouch
Copy link
Contributor Author

Aha—I think load_all got me here. Was able to knit engine docs after local install + restart. :)

Where should we document this?

Follow-up from conversation with Max: This is indeed documented here!

@simonpcouch simonpcouch marked this pull request as ready for review May 9, 2022 20:45
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonpcouch simonpcouch merged commit c6e97e6 into main May 9, 2022
@simonpcouch simonpcouch deleted the elnet-docs branch May 9, 2022 21:13
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that linear_reg() and logistic_reg() can performs elastic net regularization
3 participants