Skip to content

remove unused calls to get_model_env() #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

EmilHvitfeldt
Copy link
Member

there are a couple of places where get_model_env() is being called without having its results being used. Some of these changes date back to 218cc73

@EmilHvitfeldt EmilHvitfeldt requested a review from simonpcouch June 1, 2022 22:20
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a remarkable eye (or sneaky script) for this😄 LGTM.

@EmilHvitfeldt EmilHvitfeldt marked this pull request as ready for review June 3, 2022 20:52
@topepo topepo merged commit 6bd902a into main Jun 6, 2022
@topepo topepo deleted the remove-unused-current branch June 6, 2022 16:21
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants