Skip to content

Engine docs for h2o #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 11, 2022
Merged

Engine docs for h2o #748

merged 13 commits into from
Jun 11, 2022

Conversation

qiushiyan
Copy link
Contributor

No description provided.

@qiushiyan qiushiyan marked this pull request as draft June 6, 2022 18:00
@qiushiyan qiushiyan requested a review from topepo June 6, 2022 19:08
@simonpcouch
Copy link
Contributor

You may want to add "agua" to this vector:

parsnip/R/engine_docs.R

Lines 50 to 53 in 78e8e16

extensions <- function() {
c("baguette", "censored", "discrim", "multilevelmod", "plsmod",
"poissonreg", "rules", "bonsai")
}

and re-document so that parsnip knows where the h2o support lives and can document it in models.tsv. :)

@qiushiyan
Copy link
Contributor Author

qiushiyan commented Jun 6, 2022

Max added agua to extensions in 1b3da01. I have updated inst/models.tsv as well, thanks.

Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One suggestion below.

In the aqua PR, I mentioned making an engine for poisson_reg() so make sure to add that file here too.

@qiushiyan qiushiyan marked this pull request as ready for review June 9, 2022 21:24
@topepo topepo merged commit 1e8e215 into main Jun 11, 2022
@topepo topepo deleted the agua-docs branch June 11, 2022 23:14
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants