Skip to content

Improve readability of docs for predict.model_fit() #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Feb 8, 2023

A lot of what predict.model_fit() takes as arguments and what it returns depends on the type of prediction. To make this relatively long and detailed page easier to skim, I've replaced various different descriptions of the prediction type, with mentions of type = "<whatever the type>".

@hfrick hfrick requested a review from simonpcouch February 8, 2023 17:15
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of these changes are improvements—love it. :)

@hfrick hfrick merged commit ff20477 into main Feb 14, 2023
@hfrick hfrick deleted the predict-man branch February 14, 2023 09:18
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants