format_<prediction type>() functions only format when necessary
#922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I like the consistancy upgrade 🙌
Are these similar enough that we can have a helper function do it?
this_would_need_a_name <- function(x, col_name) {
if (isTRUE(ncol(x) > 1) | is.data.frame(x)) {
x <- as_tibble(x, .name_repair = "minimal")
if (!any(grepl(paste0("^\\", col_name), names(x)))) {
names(x) <- col_name
}
} else {
x <- tibble(unname(x))
names(x) <- col_name
x
}
}
|
Good thought - I'd say so, yes 🙌 I've introduced a helper here and added a follow-up issue #927. We might get to a general |
|
Very nice! I think this is a good improvement |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #263
The main part was done in #268 but since the issue was still open, this PR now extends it to newer prediction types.