Skip to content

correct documented modes for null_model() #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

simonpcouch
Copy link
Contributor

This PR aligns the mode argument documentation for null_model() with its registered modes:

set_model_engine("null_model", "classification", "parsnip")
set_model_engine("null_model", "regression", "parsnip")

...and the help-file's model description:

parsnip/R/nullmodel.R

Lines 130 to 131 in a85e508

#' `null_model()` defines a simple, non-informative model. It doesn't have any
#' main arguments. This function can fit classification and regression models.

Closes #982.

@simonpcouch simonpcouch merged commit e6278b0 into main Jun 23, 2023
@simonpcouch simonpcouch deleted the null-mode-982 branch June 23, 2023 12:42
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown mode for null_model
2 participants