Skip to content

Commit c1878e4

Browse files
rsaportahadley
authored andcommitted
Documentation: contributing.md (#2955)
* fixed `@seealso` link in `ggplot_gtable` * `motivates` ~~> `motivate` * indent bullet list for MD * paragraph formatting and defined `PR`
1 parent 765a277 commit c1878e4

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

CONTRIBUTING.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,15 @@ See http://docs.ggplot2.org/dev/vignettes/development.html for more details.
7979

8080
Pull requests will be evaluated against a seven point checklist:
8181

82-
1. __Motivation__. Your pull request should clearly and concisely motivates the
83-
need for change. Unfortunately neither Winston nor I have much time to
84-
work on ggplot2 these days, so you need to describe the problem and show
85-
how your pull request solves it as concisely as possible.
82+
1. __Motivation__. Your pull request should clearly and concisely motivate the
83+
need for change. Unfortunately neither Winston nor I have much time to
84+
work on ggplot2 these days, so you need to describe the problem and show
85+
how your pull request solves it as concisely as possible.
8686

87-
Also include this motivation in `NEWS` so that when a new release of
88-
ggplot2 comes out it's easy for users to see what's changed. Add your
89-
item at the top of the file and use markdown for formatting. The
90-
news item should end with `(@yourGithubUsername, #the_issue_number)`.
87+
Also include this motivation in `NEWS` so that when a new release of
88+
ggplot2 comes out it's easy for users to see what's changed. Add your
89+
item at the top of the file and use markdown for formatting. The
90+
news item should end with `(@yourGithubUsername, #the_issue_number)`.
9191

9292
1. __Only related changes__. Before you submit your pull request, please
9393
check to make sure that you haven't accidentally included any unrelated
@@ -124,8 +124,9 @@ Pull requests will be evaluated against a seven point checklist:
124124
to the appropriate function.
125125

126126
This seems like a lot of work but don't worry if your pull request isn't perfect.
127-
It's a learning process and members of the ggplot2 team will be on hand to help you out. A pull request is a process, and unless you've submitted a few in the past
128-
it's unlikely that your pull request will be accepted as is. All PRs require
127+
It's a learning process and members of the ggplot2 team will be on hand to help you
128+
out. A pull request ("PR") is a process, and unless you've submitted a few in the
129+
past it's unlikely that your pull request will be accepted as is. All PRs require
129130
review and approval from at least one member of the ggplot2 development team
130131
before merge.
131132

R/plot-build.r

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ layer_grob <- function(plot, i = 1L) {
137137
#' to (e.g.) make the legend box 2 cm wide, or combine multiple plots into
138138
#' a single display, preserving aspect ratios across the plots.
139139
#'
140-
#' @seealso [print.ggplot()] and \code{link{benchplot}} for
140+
#' @seealso [print.ggplot()] and [benchplot()] for
141141
#' for functions that contain the complete set of steps for generating
142142
#' a ggplot2 plot.
143143
#' @return a [gtable()] object

0 commit comments

Comments
 (0)