Skip to content

Documentation: contributing.md #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2018

Conversation

rsaporta
Copy link
Contributor

Minor edits to the CONTRIBUTING.md file:

  1. Typo in motivate
  2. Cleaned up bulleted-list
  3. Define PR & format the paragraph

@batpigandme
Copy link
Contributor

LGTM, @dpseidel, could you take a look at the link to benchplot()— not sure if there's something special about it.

@dpseidel
Copy link
Collaborator

@batpigandme Yep this looks good. The current code on master is not actually creating an active link. I'm not sure what this was a remnant of, especially since it's correctly linked earlier in the same file. 🤷‍♀️

@rsaporta please make sure you rebuild the package documentation and commit the new .Rd file. Then we should be ready to merge.

AFAICT the travis build errors on 3.3, 3.2, and 3.1 are related to #2956.

@karawoo
Copy link
Member

karawoo commented Oct 23, 2018

#2954 could then be closed since it contains the same commit as this one. We do also already clarify the pull request/PR abbreviation earlier in the contributing guide in step 2 here.

@hadley hadley merged commit c1878e4 into tidyverse:master Oct 23, 2018
@rsaporta rsaporta deleted the doc_typo__contributing_md branch October 24, 2018 13:29
@lock
Copy link

lock bot commented Apr 22, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants