Skip to content

Documentation: contributing.md #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ See http://docs.ggplot2.org/dev/vignettes/development.html for more details.

Pull requests will be evaluated against a seven point checklist:

1. __Motivation__. Your pull request should clearly and concisely motivates the
need for change. Unfortunately neither Winston nor I have much time to
work on ggplot2 these days, so you need to describe the problem and show
how your pull request solves it as concisely as possible.
1. __Motivation__. Your pull request should clearly and concisely motivate the
need for change. Unfortunately neither Winston nor I have much time to
work on ggplot2 these days, so you need to describe the problem and show
how your pull request solves it as concisely as possible.

Also include this motivation in `NEWS` so that when a new release of
ggplot2 comes out it's easy for users to see what's changed. Add your
item at the top of the file and use markdown for formatting. The
news item should end with `(@yourGithubUsername, #the_issue_number)`.
Also include this motivation in `NEWS` so that when a new release of
ggplot2 comes out it's easy for users to see what's changed. Add your
item at the top of the file and use markdown for formatting. The
news item should end with `(@yourGithubUsername, #the_issue_number)`.

1. __Only related changes__. Before you submit your pull request, please
check to make sure that you haven't accidentally included any unrelated
Expand Down Expand Up @@ -124,8 +124,9 @@ Pull requests will be evaluated against a seven point checklist:
to the appropriate function.

This seems like a lot of work but don't worry if your pull request isn't perfect.
It's a learning process and members of the ggplot2 team will be on hand to help you out. A pull request is a process, and unless you've submitted a few in the past
it's unlikely that your pull request will be accepted as is. All PRs require
It's a learning process and members of the ggplot2 team will be on hand to help you
out. A pull request ("PR") is a process, and unless you've submitted a few in the
past it's unlikely that your pull request will be accepted as is. All PRs require
review and approval from at least one member of the ggplot2 development team
before merge.

Expand Down
2 changes: 1 addition & 1 deletion R/plot-build.r
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ layer_grob <- function(plot, i = 1L) {
#' to (e.g.) make the legend box 2 cm wide, or combine multiple plots into
#' a single display, preserving aspect ratios across the plots.
#'
#' @seealso [print.ggplot()] and \code{link{benchplot}} for
#' @seealso [print.ggplot()] and [benchplot()] for
#' for functions that contain the complete set of steps for generating
#' a ggplot2 plot.
#' @return a [gtable()] object
Expand Down