Skip to content

Support size and linetype in geom_hex (#2488) #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2018
Merged

Support size and linetype in geom_hex (#2488) #2670

merged 4 commits into from
Jul 9, 2018

Conversation

mikmart
Copy link
Contributor

@mikmart mikmart commented May 29, 2018

Fixes #2488: size (and additionally linetype) can now be used in geom_hex() to control the bordering lines of the hexagons.

ggplot(diamonds, aes(carat, price)) +
  geom_hex(col = "red", size = 2)

@hadley
Copy link
Member

hadley commented Jul 8, 2018

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).

@hadley
Copy link
Member

hadley commented Jul 8, 2018

Also can you please use Fixes #2488 — that specific wording will cause the related issue to be automatically closed when this PR is merged.

@mikmart
Copy link
Contributor Author

mikmart commented Jul 9, 2018

Sure! I've updated the PR comment to use Fixes, and also added the NEWS bullet (hopefully correctly).

This is my first PR, and I'm a bit new to Git, so hopefully the NEWS bullet addition is OK; I had some trouble with incorporating all the other commits that happened since I opened the PR, (tried to rebase branch with upstream, pull origin, and then push; but that ended up with 30 commits in this branch somehow -- forced a reset on that), so I ended up just doing a deliberate merge conflict to be able to add the bullet without too much of a mess.

@hadley
Copy link
Member

hadley commented Jul 9, 2018

Looks good, thanks!

@hadley hadley merged commit e0797dc into tidyverse:master Jul 9, 2018
@lock
Copy link

lock bot commented Jan 5, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants