Make legend.box.background work for theme_void() #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jul 8, 2018
| @@ -263,7 +263,7 @@ guides_build <- function(ggrobs, theme) { | |||
| # add space between the guide-boxes | |||
| guides <- gtable_add_col_space(guides, theme$legend.spacing.x) | |||
|
|
|||
| } else if (theme$legend.box == "vertical") { | |||
| } else { # theme$legend.box == "vertical" | |||
There was a problem hiding this comment.
Can you change the test in the first block to use identical()? That's safer if theme$legend.box is somehow not a length-1 vector. (I'm surprised the user of NULL doesn't cause a warning, TBH)
hadley
approved these changes
Jul 9, 2018
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #2723.
One thing I wasn't sure about was whether I should add all the missing legend theme parameters in
theme_void(). There are more than justlegend.box. I tried copying them over fromtheme_grey()but that caused changed spacing in two visual tests so I reverted.