fix up NEWS.md for release #2921
Conversation
|
I don't mind either way about authorship — when I wrote that advice, I was mostly thinking of my team at RStudio. |
|
@hadley Ok, then I'll leave them in. @batpigandme Any copy edits from your side? |
| (@clauswilke, #2846). | ||
| This is a minor release and breaking changes have been kept to a minimum. End users of ggplot2 are unlikely to encounter any issues. However, there are a few items that developers of ggplot2 extensions should be aware of. For additional details, see also the discussion accompanying issue #2890. | ||
|
|
||
| * In non-user-facing internal code (specifically in the `aes()` function and in |
There was a problem hiding this comment.
Switch "of" to "for" for "British spelling for aesthetics…"? (I had a split second of wondering how the British spell the word of aesthetics)
NEWS.md
Outdated
| * In non-user-facing internal code (specifically in the `aes()` function and in | ||
| the `aesthetics` argument of scale functions), ggplot2 now always uses the British | ||
| spelling of aesthetics containing the word "colour". When users specify a "color" | ||
| aesthetic it is automatically renamed to "colour". This principle is also applied |
There was a problem hiding this comment.
Simplify the "This principle is also…" to "This also applies to non-standard aesthetics…" ?
(stylistic, it's fine either way)
There was a problem hiding this comment.
I normally try to avoid using "this" as a pronoun (as opposed to a modifier), as it leads to imprecise writing. But I agree that "this principle" is awkward, so maybe imprecise is better here.
There was a problem hiding this comment.
I think "this renaming" works better than just "this":
When users specify a "color" aesthetic it is automatically renamed to "colour". This renaming is also applied to non-standard aesthetics that contain the word "color".
versus:
When users specify a "color" aesthetic it is automatically renamed to "colour". This is also applied to non-standard aesthetics that contain the word "color".
NEWS.md
Outdated
| aesthetic it is automatically renamed to "colour". This principle is also applied | ||
| to non-standard aesthetics that contain the word "color". For example, "point_color" | ||
| is renamed to "point_colour". This convention makes it easier to support both | ||
| British and American spelling for novel non-standard aesthetics, but it may require |
There was a problem hiding this comment.
Comma after novel? (though I guess non-standard aesthetics could be considered the noun phrase — so, again, tossup!)
| is renamed to "point_colour". This convention makes it easier to support both | ||
| British and American spelling for novel non-standard aesthetics, but it may require | ||
| some adjustment for packages that have previously introduced non-standard color | ||
| aesthetics using American spelling. A new function `standardise_aes_names()` is |
There was a problem hiding this comment.
Style-wise, I think the goal has been to have the new function near the front of the bullet (see http://style.tidyverse.org/news.html#common-patterns), but I get why it's not in this case.
There was a problem hiding this comment.
Yeah, I think I'll leave it as is.
NEWS.md
Outdated
|
|
||
| * `benchplot()` now uses tidy evaluation (@dpseidel, #2699). | ||
|
|
||
| * The error message in `compute_aesthetics()` now provides the names of only |
There was a problem hiding this comment.
Awk word ordering here, maybe change to: "now only provides the names of aesthetics…" or "now returns the names only for aesthetics…"
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
I have taken a first stab at NEWS.md.
@hadley According to the style guide, package authors should not be listed for items they wrote. Do you want me to remove @clauswilke and @karawoo from all 3.1.0 news items? (I think no other contributors are official authors.)