Treat data as list during position transformation #3002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
changed the title
hadley
reviewed
Nov 15, 2018
| @@ -75,6 +75,8 @@ Position <- ggproto("Position", | |||
| #' @keywords internal | |||
| #' @export | |||
| transform_position <- function(df, trans_x = NULL, trans_y = NULL, ...) { | |||
| oldclass <- class(df) | |||
There was a problem hiding this comment.
Would it be better to implement with a custom df_cols<- ?
There was a problem hiding this comment.
I haven't found a performant data.frame setter except for unclassing and classing... If you know one then it would indeed be more pretty...
hadley
approved these changes
Nov 19, 2018
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR treats the data frame in
transform_positionas a list for the duration of the call, speeding upggplot_buildup by some 30% for a simple faceted boxplot of mtcars