Skip to content

Remove duplicated grDevices in Imports #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2018
Merged

Remove duplicated grDevices in Imports #3009

merged 1 commit into from
Nov 19, 2018

Conversation

yutannihilation
Copy link
Member

To fix this NOTE:

* checking DESCRIPTION meta-information ... NOTE
Package listed in more than one of Depends, Imports, Suggests, Enhances:
  ‘grDevices’
A package should be listed in only one of these fields.

https://travis-ci.org/tidyverse/ggplot2/jobs/455860461#L2326

@hadley hadley requested a review from thomasp85 November 19, 2018 13:37
thomasp85
thomasp85 approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yutannihilation yutannihilation merged commit a057a26 into tidyverse:master Nov 19, 2018
@yutannihilation yutannihilation deleted the remove-duplicated-imports branch November 19, 2018 13:45
@lock
Copy link

lock bot commented May 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutannihilation @thomasp85