Skip to content

Complete list of built-in transformations derived from scales::name_trans #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Conversation

Henrik-P
Copy link

No description provided.

@yutannihilation
Copy link
Member

Thanks, could you update the docs by running devtools::document()?

@Henrik-P
Copy link
Author

Sorry, I'm not familiar with the devtools::document() procedure. When searching I ended up here: The documentation workflow. Have I understood it correctly that I start by saving a hard copy of the "scale-.r" file, then render it in RStudio devtools::document()?

@yutannihilation
Copy link
Member

Have I understood it correctly that I start by saving a hard copy of the "scale-.r" file,

No. How did you make this pull request? (I'm happy to generate the docs for you, but I want to help you if possible.)

@Henrik-P
Copy link
Author

Henrik-P commented Feb 19, 2019

How did you make this pull request?

I have a ggplot repository "Forked from tidyverse/ggplot2". I made the relevant changes there in "scale-.r". Went back to tidyverse/ggplot, Compare changes / compare across forks, select my repository as 'head repository', 'Create pull request'.

Sorry for my ignorance.

@yutannihilation
Copy link
Member

No need to feel sorry!

Thanks for the details. It seems you need to get familiar with git and RStudio (or some other tools) a bit more, so let me do devtools::document() this time. You could

  1. clone your ggplot2 repo in your local
  2. run devtools::document() on the root directory of ggplot2
  3. commit the changes
  4. push to GitHub

c.f. https://happygitwithr.com/rstudio-git-github.html#clone-the-new-github-repository-to-your-computer-via-rstudio

@yutannihilation yutannihilation merged commit 033fb52 into tidyverse:master Feb 19, 2019
@yutannihilation
Copy link
Member

Thanks for your contribution 👍

@Henrik-P
Copy link
Author

Thanks for your kind words and for pointing me to relevant git docs.

@lock
Copy link

lock bot commented Aug 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants