Skip to content

Update tidy eval reexport file #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update tidy eval reexport file #3308

wants to merge 2 commits into from

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented May 7, 2019

New template from usethis.

The main changes are to export as_label() and as_name(), and to undocument stuff that should no longer be exported, but that we keep exporting for compatibility (enexpr(), quo(), quo_name(), etc).

@yutannihilation
Copy link
Member

Probably, this version requirement needs to be tightened to 3.1.

rlang (>= 0.3.0),

@lionel-
Copy link
Member Author

lionel- commented May 7, 2019

I'm about to send a PR for 3.1, currently being checked on travis: https://travis-ci.org/tidyverse/ggplot2/builds/529211641

@yutannihilation
Copy link
Member

Aw, sorry, I meant 0.3.1, the version of rlang when as_name() and as_label() were introduced.

@lionel- lionel- force-pushed the fix-tidy-eval-compat branch from bf9842c to 5325290 Compare May 7, 2019 11:32
@lionel-
Copy link
Member Author

lionel- commented May 7, 2019

Aw, sorry, I meant 0.3.1, the version of rlang when as_name() and as_label() were introduced.

ah yes good point!

@lionel- lionel- mentioned this pull request May 7, 2019
@hadley
Copy link
Member

hadley commented May 20, 2019

I'm worried that this might cause revdep failures (because of namespace conflicts, which are common with ggplot2 revdeps), so I think we should wait until the next version for this.

@thomasp85
Copy link
Member

@hadley are we good to go on this now?

@hadley
Copy link
Member

hadley commented Aug 26, 2019

I think we probably need to reconsider this completely now. I suspect expr(), enquo(), enquos(), sym(), and syms()can now be considered advanced usage any only:=and.data` really need to be exported. But I think we need to have that discussion elsewhere, so I'd recommend closing this PR. (But you should bump the R version requirement to be consistent with the rest of the tidyverse)

@yutannihilation
Copy link
Member

We bumped already in #3309

@thomasp85 thomasp85 closed this Aug 26, 2019
@lock
Copy link

lock bot commented Feb 22, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants