Skip to content

Cleanup Travis config #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Cleanup Travis config #3354

merged 1 commit into from
Jul 24, 2019

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jun 5, 2019

Using declarative installation of apt packages will result in better caching. Also sudo is deprecated and dist: trusty is EOL soon, it's better to use the default linux distribution.

@yutannihilation
Copy link
Member

yutannihilation commented Jul 24, 2019

It seems Travis still uses Trusty here. So, we might need some additional tweaks when actually migrate to Xenial.

https://travis-ci.org/tidyverse/ggplot2/jobs/541740990#L9

Anyway, I think we should merge this as Trusty is already EOL. Unless there's some concern, I'll merge this.

c.f. https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment

@yutannihilation yutannihilation merged commit 141c775 into tidyverse:master Jul 24, 2019
@yutannihilation
Copy link
Member

Confirmed tests run fine on Xenial with my forked repo: https://travis-ci.org/yutannihilation/ggplot2/builds/563266792

The main repo stays on Trusty even after I cleared the build cache, but I think we can just wait for their migration is done: https://travis-ci.org/yutannihilation/ggplot2/builds/563266792

@lock
Copy link

lock bot commented Jan 24, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants